Skip to content

docs(path): fix malformed comment in cleanPath - #4723

Merged
appleboy merged 1 commit into
gin-gonic:masterfrom
Amirhf1:fix/path-malformed-comment
Aug 15, 2026
Merged

docs(path): fix malformed comment in cleanPath#4723
appleboy merged 1 commit into
gin-gonic:masterfrom
Amirhf1:fix/path-malformed-comment

Conversation

@Amirhf1

@Amirhf1 Amirhf1 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

A previous commit (64e6a76) that improved comments in cleanPath
accidentally merged two comment lines into a single malformed line:

// loop has no expensive function calls (except 1x make)		// So in contrast to the path package this loop has no expensive function

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.32%. Comparing base (3dc1cd6) to head (189c49c).
⚠️ Report is 292 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4723      +/-   ##
==========================================
- Coverage   99.21%   98.32%   -0.89%     
==========================================
  Files          42       48       +6     
  Lines        3182     3172      -10     
==========================================
- Hits         3157     3119      -38     
- Misses         17       43      +26     
- Partials        8       10       +2     
Flag Coverage Δ
?
--ldflags="-checklinkname=0" -tags sonic 98.31% <ø> (?)
-tags go_json 98.25% <ø> (?)
-tags nomsgpack 98.30% <ø> (?)
go-1.18 ?
go-1.19 ?
go-1.20 ?
go-1.21 ?
go-1.25 98.32% <ø> (?)
go-1.26 98.32% <ø> (?)
macos-latest 98.32% <ø> (-0.89%) ⬇️
ubuntu-latest 98.32% <ø> (-0.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@appleboy appleboy added this to the v1.13 milestone Aug 15, 2026
@appleboy
appleboy merged commit dcaa429 into gin-gonic:master Aug 15, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants