feat(context): unwrap joined errors in Context.Error() - #4729
Open
Vierblatt wants to merge 2 commits into
Open
Conversation
errors.Join() produces a single error implementing Unwrap() []error. Previously, c.Error(errors.Join(e1, e2)) stored the joined error as one entry, confusing errorMsgs output. Now each unwrapped error becomes an individual entry, with gin.Error type preserved when applicable. Fixes gin-gonic#4237
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4729 +/- ##
==========================================
- Coverage 99.21% 98.33% -0.89%
==========================================
Files 42 48 +6
Lines 3182 3178 -4
==========================================
- Hits 3157 3125 -32
- Misses 17 43 +26
- Partials 8 10 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context.Error()now detects errors implementingUnwrap() []error(like those fromerrors.Join) and stores each unwrapped error as an individual entry inc.Errors*gin.Errortype metadata when a joined error contains oneUnwrap()returns an empty sliceMotivation
Fixes #4237. When
errors.Join(e1, e2)is passed toc.Error(), the joined error was stored as a single entry. This produced confusing output inerrorMsgs.String()where the joined error's own\n-separated format mixed with Gin's numbered format:Now each joined error becomes its own numbered entry.
Test plan
errors.Join(err1, err2)unwraps into two entrieserrors.Joinrecursively unwraps*gin.Errortype preserved inside a joinUnwrap() []errordegrades to single wrapped entry