test(utils): cover EncodeToken error path in H.MarshalXML - #4739
Open
c879873067877881111 wants to merge 1 commit into
Open
test(utils): cover EncodeToken error path in H.MarshalXML#4739c879873067877881111 wants to merge 1 commit into
c879873067877881111 wants to merge 1 commit into
Conversation
H.MarshalXML returns early when the opening e.EncodeToken(start) call fails, but no test covered that error path. Because xml.Encoder buffers its output, the underlying writer is not called until the buffer flushes. The test writes an 8KB token first to push the encoder into an error state, then calls MarshalXML and asserts the write error is propagated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4739 +/- ##
==========================================
- Coverage 99.21% 98.39% -0.83%
==========================================
Files 42 48 +6
Lines 3182 3172 -10
==========================================
- Hits 3157 3121 -36
- Misses 17 42 +25
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.