fix(recovery): mask Cookie and Proxy-Authorization in panic dumps - #4744
Open
sonnemusk wants to merge 1 commit into
Open
fix(recovery): mask Cookie and Proxy-Authorization in panic dumps#4744sonnemusk wants to merge 1 commit into
sonnemusk wants to merge 1 commit into
Conversation
Panic recovery logs dump the request for debugging. Only Authorization was redacted, so session cookies and proxy credentials could still leak into logs. Mask Cookie and Proxy-Authorization the same way.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4744 +/- ##
==========================================
- Coverage 99.21% 98.39% -0.82%
==========================================
Files 42 48 +6
Lines 3182 3181 -1
==========================================
- Hits 3157 3130 -27
- Misses 17 41 +24
- Partials 8 10 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secureRequestDumpis used when Recovery middleware logs a panic. Previously onlyAuthorizationwas redacted, so session cookies and proxy credentials could still appear in logs.This change also masks:
CookieProxy-AuthorizationHeader matching is done by field name (case-insensitive) so the dump stays stable across
http.Headercanonicalization.Test plan
TestSecureRequestDumpfor Cookie / Proxy-Authorization / multi-header casesgo test -count=1 -run TestSecureRequestDump .go test -count=1 .