Repository navigation
improve/simplify trusted dir handling - #2
Merged
Merged
Conversation
MichaelMure
force-pushed
the
trusted-dit
branch
from
October 9, 2026 18:06
fb8402e to
cc7f7c1
Compare
MichaelMure
force-pushed
the
trusted-dit
branch
from
October 9, 2026 18:53
cc7f7c1 to
903a1d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Confidence Score: 5/5 
The PR appears safe to merge; both numbered Windows findings are fixed, and no new actionable issue was found.Summary
Moves repository trust checks into
Discover, which now accepts a working-tree path and returnsErrUntrustedwhen ownership and protectedsafe.directorysettings do not allow it.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A["Discover(dir)"] --> B["Find the git directory and paths to check"] B --> C{"All existing paths owned?"} C -->|Yes| F["Return Env"] C -->|No| D["Load protected settings with GitDir cleared"] D --> E{"safe.directory allows the path?"} E -->|Yes| F E -->|No| G["Return ErrUntrusted"]Reviews (3) · Last reviewed commit: "improve/simplify trusted dir handling" · Reviewed by Greptile