Skip to content

Scope Linux connector regression to Linux - #51

Merged
gitcommit90 merged 1 commit into
mainfrom
fix/linux-only-connector-test
Aug 1, 2026
Merged

Scope Linux connector regression to Linux#51
gitcommit90 merged 1 commit into
mainfrom
fix/linux-only-connector-test

Conversation

@gitcommit90

@gitcommit90 gitcommit90 commented Aug 1, 2026

Copy link
Copy Markdown
Owner

The fresh Linux systemd connector regression creates a Linux-architecture bundled resource and must run only on Linux. This preserves the real Linux assertion while allowing the required Mac and Windows release gates to run from the same source.

Summary by CodeRabbit

  • Tests
    • Updated the Linux service working-directory test to skip cleanly on non-Linux platforms.
    • Prevented unnecessary temporary resource creation and module loading when the test is not applicable.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 20856f29-183b-41ef-bae8-fc726681ed98

📥 Commits

Reviewing files that changed from the base of the PR and between acbc5e1 and 617aa2b.

📒 Files selected for processing (1)
  • test/connectors.mjs

📝 Walkthrough

Walkthrough

The working-directory test now skips on non-Linux platforms before creating temporary resources or importing the connector module.

Changes

Connector test guard

Layer / File(s) Summary
Linux platform guard
test/connectors.mjs
The working-directory test checks the platform, skips on non-Linux systems, and returns before Linux-specific setup.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change and its purpose but omits the required template sections, including type, release notes, acceptance ledger, and verification. Complete the required template sections and record the change type, release-note status, acceptance evidence, verification results, and impact considerations.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the Linux-only scope added to the connector regression test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/linux-only-connector-test

Comment @coderabbitai help to get the list of available commands.

@gitcommit90
gitcommit90 merged commit 5437442 into main Aug 1, 2026
6 checks passed
@gitcommit90
gitcommit90 deleted the fix/linux-only-connector-test branch August 1, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant