JS: Do not warn about browser-specific source kinds in MaD - #22241
Open
asgerf wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds supported browser-specific JavaScript source kinds to MaD validation, preventing incorrect warnings.
Changes:
- Extends the valid source-kind allowlist with all browser source kinds.
Show a summary per file
| File | Description |
|---|---|
shared/mad/codeql/mad/ModelValidation.qll |
Registers browser-specific JavaScript source kinds. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
Contributor
Author
Rerun has been triggered: 3 restarted 🚀 |
aschackmull
approved these changes
Jul 28, 2026
Contributor
Author
Rerun has been triggered: 1 restarted 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser-specific source kinds are already supported, but our tests currently warn about them because they weren't listed in
ModelValidation.qll