Skip to content

C++: Add flow sources for winreg.h #22242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathiasVP merged 7 commits into from
Jul 28, 2026
Merged

C++: Add flow sources for winreg.h #22242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b5cb703
C++: Add tests with missing flow sources.
MathiasVP Jul 28, 2026
16ad0a3
C++: Add flow sources for 'winreg.h'.
MathiasVP Jul 28, 2026
154b3b1
C++: Accept test changes.
MathiasVP Jul 28, 2026
7bd322a
C++: Add change note.
MathiasVP Jul 28, 2026
b0f345a
C++: Add a test for 'RegGetValueA'.
MathiasVP Jul 28, 2026
daefacf
C++: Add models for 'RegGetValue' and friends.
MathiasVP Jul 28, 2026
034a90b
C++: Accept test changes.
MathiasVP Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cpp/ql/lib/change-notes/2026-07-28-winreg-sources.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Added flow source models for `RegQueryValue` and related functions from the `winreg.h` Windows header.
11 changes: 11 additions & 0 deletions cpp/ql/lib/ext/Windows.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,17 @@ extensions:
- ["", "", False, "HttpReceiveHttpRequest", "", "", "Argument[*3]", "remote", "manual"]
- ["", "", False, "HttpReceiveRequestEntityBody", "", "", "Argument[*3]", "remote", "manual"]
- ["", "", False, "HttpReceiveClientCertificate", "", "", "Argument[*3]", "remote", "manual"]
# winreg.h
- ["", "", False, "RegQueryValueA", "", "", "Argument[*2]", "local", "manual"]
Comment thread
MathiasVP marked this conversation as resolved.
- ["", "", False, "RegQueryValueExA", "", "", "Argument[*4]", "local", "manual"]
- ["", "", False, "RegQueryValueW", "", "", "Argument[*2]", "local", "manual"]
- ["", "", False, "RegQueryValueExW", "", "", "Argument[*4]", "local", "manual"]
- ["", "", False, "RegGetValueA", "", "", "Argument[*5]", "local", "manual"]
- ["", "", False, "RegGetValueW", "", "", "Argument[*5]", "local", "manual"]
# TODO: Once we support access paths at sources we should also mark Argument[*1].Field[*ve_valueptr]
- ["", "", False, "RegQueryMultipleValuesA", "", "", "Argument[*3]", "local", "manual"]
# TODO: Once we support access paths at sources we should also mark Argument[*1].Field[*ve_valueptr]
- ["", "", False, "RegQueryMultipleValuesW", "", "", "Argument[*3]", "local", "manual"]
- addsTo:
pack: codeql/cpp-all
extensible: summaryModel
Expand Down
Loading
Loading