[Test Coverage] docker-manager.ts - #7822
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Extends barrel-module tests to cover capability-filter re-exports.
Changes:
- Verifies all four capability-filter exports.
- Updates the exhaustive export list.
- Adds basic invocation checks.
Show a summary per file
| File | Description |
|---|---|
src/docker-manager.test.ts |
Adds coverage for capability-filter barrel exports. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
|
✅ Copilot review passed with no inline comments. @github-actions[bot] Add the |
|
🔌 Smoke Services — All services reachable! ✅
|
|
❌ Smoke Gemini reports failed. Facets need polishing...
|
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤
|
|
✅ Smoke Claude passed
|
|
✅ Build Test Suite completed successfully!
|
|
🚀 Security Guard has started processing this pull request |
|
✅ Contribution Check completed successfully! Contribution check complete: the PR is aligned with CONTRIBUTING.md. It includes tests for the new export wiring, the change stays in the correct
|
|
✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓
|
|
🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅ Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓
|
|
📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤
|
|
✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓
|
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅
|
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.
|
Smoke Test: Claude Engine Validation
Overall result: PASS
|
|
EGRESS_RESULT allow=pass deny=pass ✅ Allowed domain (api.github.com) reachable — Overall: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
|
Smoke Test: Copilot BYOK (Direct) Mode ✅
Status: PASS Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy sidecar to api.githubcopilot.com.
|
|
Smoke Test: Copilot Engine —
Overall: PASS
|
Smoke Test
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Smoke Test: GitHub Actions Services Connectivity
Overall: FAIL —
|
|
|
|
Upgrade gh-aw workflows to v0.87.8
|
|
Docker Sbx Smoke Test
Overall: PASS cc
|
Smoke Test: API Proxy OpenTelemetry Tracing — ✅ All Scenarios Pass
No issues found; no follow-up action needed.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — PASS Notes:
|
Chroot Test Results
Overall: FAILED — Node.js version mismatch between host and chroot environments (v24.19.0 vs v22.23.2).
|
Summary
Extends
src/docker-manager.test.tsto fully cover thedocker-manager.tsbarrel module, which previously only verified re-exports fromhost-env,config-writer,container-lifecycle, andcontainer-cleanupbut omitted thecapability-filterre-exports (filterCapDrop,filterComposeCapDrop,getHostCapabilityBoundingSet,isCapDropSkipped).Changes
capability-filtersymbols are re-exported as functions.filterCapDropandisCapDropSkippedthrough the barrel re-export path, for direct coverage of the barrel's export wiring (detailed behavior remains covered incapability-filter.test.ts).Coverage impact
docker-manager.tsbarrel module: 100% statements / 100% branches / 100% functions / 100% lines (was previously incomplete on functions coverage for this file due to the missing capability-filter export test, and the exhaustive-export test would fail against current exports).Verification
All 8 tests pass; 100% coverage on
docker-manager.ts.