Skip to content

[Test Coverage] docker-manager.ts - #7822

Merged
lpcox merged 1 commit into
mainfrom
test-coverage/docker-manager-cap-filter-exports-58220f65e6c8e611
Aug 28, 2026
Merged

[Test Coverage] docker-manager.ts#7822
lpcox merged 1 commit into
mainfrom
test-coverage/docker-manager-cap-filter-exports-58220f65e6c8e611

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Summary

Extends src/docker-manager.test.ts to fully cover the docker-manager.ts barrel module, which previously only verified re-exports from host-env, config-writer, container-lifecycle, and container-cleanup but omitted the capability-filter re-exports (filterCapDrop, filterComposeCapDrop, getHostCapabilityBoundingSet, isCapDropSkipped).

Changes

  • Added assertions verifying capability-filter symbols are re-exported as functions.
  • Updated the "no unexpected additional exports" exhaustive-export-list test to include the four capability-filter symbols (this test was previously failing/incomplete against the actual barrel exports).
  • Added two lightweight sanity tests exercising filterCapDrop and isCapDropSkipped through the barrel re-export path, for direct coverage of the barrel's export wiring (detailed behavior remains covered in capability-filter.test.ts).

Coverage impact

docker-manager.ts barrel module: 100% statements / 100% branches / 100% functions / 100% lines (was previously incomplete on functions coverage for this file due to the missing capability-filter export test, and the exhaustive-export test would fail against current exports).

Verification

./node_modules/.bin/jest --testPathPatterns=docker-manager.test.ts --coverage --collectCoverageFrom=src/docker-manager.ts

All 8 tests pass; 100% coverage on docker-manager.ts.

Generated by Test Coverage Improver · copilot · auto · 51.1 AIC · ⊞ 9.6K ·

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@lpcox
lpcox marked this pull request as ready for review August 28, 2026 15:01
Copilot AI balanced review requested due to automatic review settings August 28, 2026 15:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends barrel-module tests to cover capability-filter re-exports.

Changes:

  • Verifies all four capability-filter exports.
  • Updates the exhaustive export list.
  • Adds basic invocation checks.
Show a summary per file
File Description
src/docker-manager.test.ts Adds coverage for capability-filter barrel exports.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@github-actions

Copy link
Copy Markdown
Contributor Author

✅ Copilot review passed with no inline comments.

@github-actions[bot] Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

🔌 Smoke Services — All services reachable! ✅

🔌 Service connectivity validated by Smoke Services

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Gemini reports failed. Facets need polishing...

💎 Faceted by Smoke Gemini

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

📰 BREAKING: Report filed by Smoke Copilot

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Claude passed

Generated by Smoke Claude for #7822

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Build Test Suite completed successfully!

Generated by Build Test Suite for #7822

@github-actions

Copy link
Copy Markdown
Contributor Author

🚀 Security Guard has started processing this pull request

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Contribution Check completed successfully!

Contribution check complete: the PR is aligned with CONTRIBUTING.md. It includes tests for the new export wiring, the change stays in the correct src/ location, and the PR description clearly explains the coverage update with verification details. No comment needed.

Generated by Contribution Check for #7822

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • example.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "example.com"

See Network Configuration for more information.

🛡️ Egress verdict from Smoke Copilot Network Isolation

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

🔑 BYOK report filed by Smoke Copilot BYOK

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤

📰 BREAKING: Report filed by Smoke Docker Sbx

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

@lpcox
lpcox deployed to aoai-model August 28, 2026 16:02 — with GitHub Actions Active
@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

📡 OTel tracing validated by Smoke OTel Tracing

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

Tested by Smoke Chroot

@github-actions

Copy link
Copy Markdown
Contributor Author

Smoke Test: Claude Engine Validation

Check Status
API ✅ PASS
gh CLI ✅ PASS
File ✅ PASS

Overall result: PASS

Generated by Smoke Claude for #7822 · claude · haiku45 · 56.1 AIC · ⊞ 4.5K ·
Add label ready-for-aw to run again

@github-actions github-actions Bot added smoke-claude smoke-copilot-network-isolation Copilot network-isolation egress smoke test labels Aug 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor Author

@lpcox Smoke test results for Copilot network isolation:

EGRESS_RESULT allow=pass deny=pass

✅ Allowed domain (api.github.com) reachable — allowed=200
✅ Blocked domain (example.com) denied — 403 CONNECT tunnel failed

Overall: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • example.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "example.com"

See Network Configuration for more information.

🛡️ Egress verdict from Smoke Copilot Network Isolation
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Smoke Test: Copilot BYOK (Direct) Mode

  • ✅ GitHub MCP: Connected (merged PRs verified)
  • ✅ GitHub.com: HTTP 200 OK
  • ✅ File Write/Read: Confirmed
  • ✅ BYOK Inference: Working (direct mode via api-proxy → api.githubcopilot.com)

Status: PASS

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy sidecar to api.githubcopilot.com. @lpcox

🔑 BYOK report filed by Smoke Copilot BYOK
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Smoke Test: Copilot Engine@lpcox

Overall: PASS

📰 BREAKING: Report filed by Smoke Copilot
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Smoke Test

  • PR titles: chore: upgrade gh-aw prerelease workflows; Recompile enclave smoke with gateway key handoff
  • GitHub MCP review/query: ❌
  • Playwright GitHub title: ✅
  • File write + cat: ✅
  • npm ci && npm run build: ✅
  • Discussion query/comment: ❌
  • Overall: FAIL

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
Add label ready-for-aw to run again

@lpcox
lpcox deployed to aoai-model August 28, 2026 16:06 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor Author

Smoke Test: GitHub Actions Services Connectivity

  • Redis: ❌ Temporary failure in name resolution
  • PostgreSQL pg_isready: ❌ no response
  • PostgreSQL SELECT 1: ❌ could not translate host name

Overall: FAILhost.docker.internal DNS resolution failed inside the AWF sandbox.

🔌 Service connectivity validated by Smoke Services
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

@github-actions[bot]

  • [Test Coverage] docker-manager.ts: ✅
  • Log the resolved filesystem.allowWrite boundary before the Cloud Hypervisor guest boots: ✅
  • GitHub MCP: ✅
  • GitHub.com Connectivity: ✅
  • Agent file I/O: ✅
  • BYOK inference path: ✅
    Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)
    Overall: PASS

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Upgrade gh-aw workflows to v0.87.8
refactor: split Cloud Hypervisor backend helpers
✅ GitHub MCP connectivity
✅ GitHub.com connectivity
✅ File write/read test
✅ BYOK inference test
Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra
Overall: PASS
@lpcox

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Docker Sbx Smoke Test

Overall: PASS

cc @lpcox

📰 BREAKING: Report filed by Smoke Docker Sbx
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Smoke Test: API Proxy OpenTelemetry Tracing — ✅ All Scenarios Pass

  • Module Loading: otel.js loaded successfully, isEnabled() returns true, exports include startRequestSpan, setTokenAttributes, setBudgetAttributes, endSpan, endSpanError, shutdown, etc.
  • Test Suite: 3 suites / 68 tests passed (otel.test.js, otel-fanout.test.js, otel-workload-identity.test.js).
  • Env Var Forwarding: env-passthrough.ts forwards GITHUB_AW_OTEL_TRACE_ID and GITHUB_AW_OTEL_PARENT_SPAN_ID; api-proxy-env-config.ts forwards GH_AW_OTLP_ENDPOINTS, OTEL_EXPORTER_OTLP_ENDPOINT, and the trace context vars.
  • Token Tracker Integration: token-tracker-http.js contains the onUsage callback hook point.
  • OTEL Diagnostics: otel.jsonl contains exported spans (e.g. gh-aw.agent.setup) with resource/GenAI attributes, confirming spans were produced and captured during this run.

No issues found; no follow-up action needed.

📡 OTel tracing validated by Smoke OTel Tracing
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

🏗️ Build Test Suite Results

Ecosystem Project Build/Install Tests Status
Bun elysia 1/1 passed ✅ PASS
Bun hono 1/1 passed ✅ PASS
C++ fmt N/A ✅ PASS
C++ json N/A ✅ PASS
Deno oak N/A 1/1 passed ✅ PASS
Deno std N/A 1/1 passed ✅ PASS
.NET hello-world N/A (ran OK) ✅ PASS
.NET json-parse N/A (ran OK) ✅ PASS
Go color pass ✅ PASS
Go env pass ✅ PASS
Go uuid pass ✅ PASS
Java gson 1/1 passed ✅ PASS
Java caffeine 1/1 passed ✅ PASS
Node.js clsx all passed ✅ PASS
Node.js execa all passed ✅ PASS
Node.js p-limit all passed ✅ PASS
Rust fd 1/1 passed ✅ PASS
Rust zoxide 1/1 passed ✅ PASS

Overall: 8/8 ecosystems passed — PASS

Notes:

  • Java: Maven's default local repo (~/.m2/repository) wasn't writable in this environment, so builds used -Dmaven.repo.local=/tmp/gh-aw/agent/m2repo as a local workaround (settings.xml proxy config was applied as instructed). This did not affect pass/fail results.
  • All clones succeeded; no CLONE_FAILED cases.

Generated by Build Test Suite for #7822 · copilot · auto · 57.1 AIC · ⊞ 12K ·
Add label ready-for-aw to run again

@github-actions

Copy link
Copy Markdown
Contributor Author

Chroot Test Results

Runtime Host Version Chroot Version Match?
Python Python 3.12.14 Python 3.12.14 ✅ YES
Node.js v24.19.0 v22.23.2 ❌ NO
Go go1.22.12 go1.22.12 ✅ YES

Overall: FAILED — Node.js version mismatch between host and chroot environments (v24.19.0 vs v22.23.2). smoke-chroot label not applied.

Tested by Smoke Chroot
Add label ready-for-aw to run again

@lpcox
lpcox merged commit d9b1991 into main Aug 28, 2026
160 of 163 checks passed
@lpcox
lpcox deleted the test-coverage/docker-manager-cap-filter-exports-58220f65e6c8e611 branch August 28, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants