Skip to content

fix: update stale cache-key fixture in BenchmarkCompileMCPWorkflow - #48679

Merged
pelikhan merged 2 commits into
mainfrom
copilot/fix-stale-cache-key-fixture
Jul 28, 2026
Merged

fix: update stale cache-key fixture in BenchmarkCompileMCPWorkflow#48679
pelikhan merged 2 commits into
mainfrom
copilot/fix-stale-cache-key-fixture

Conversation

Copilot AI commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

BenchmarkCompileMCPWorkflow was failing because its test fixture used github.run_id directly in a cache-memory key — now rejected by the compiler's cache-key validation, which disallows run_id in user-supplied keys since the compiler appends it automatically.

Change

Updated the fixture's cache key in compiler_performance_benchmark_test.go:

# Before (rejected — run_id in user key prevents cross-run cache restoration)
cache-memory:
  key: pr-${{ github.run_id }}

# After
cache-memory:
  key: pr-${{ env.GH_AW_WORKFLOW_ID_SANITIZED }}

The cache key `pr-${{ github.run_id }}` was rejected by the compiler's
cache-key validation (which disallows github.run_id in user-supplied keys
since the compiler appends it automatically). Updated to use
`pr-${{ env.GH_AW_WORKFLOW_ID_SANITIZED }}` which is the recommended pattern.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix stale cache key in BenchmarkCompileMCPWorkflow fix: update stale cache-key fixture in BenchmarkCompileMCPWorkflow Jul 28, 2026
Copilot AI requested a review from pelikhan July 28, 2026 16:09
@pelikhan
pelikhan marked this pull request as ready for review July 28, 2026 16:12
Copilot AI review requested due to automatic review settings July 28, 2026 16:12
@pelikhan
pelikhan merged commit 2f2834f into main Jul 28, 2026
1 check passed
@pelikhan
pelikhan deleted the copilot/fix-stale-cache-key-fixture branch July 28, 2026 16:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the stale benchmark fixture to comply with cache-key validation and restore BenchmarkCompileMCPWorkflow, fixing #48676.

Changes:

  • Replaces the prohibited github.run_id expression with the stable sanitized workflow ID.
Show a summary per file
File Description
pkg/workflow/compiler_performance_benchmark_test.go Updates the MCP benchmark cache key fixture.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Medium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[performance] Daily benchmark: BenchmarkCompileMCPWorkflow fails due to stale cache-key fixture

3 participants