fix: update stale cache-key fixture in BenchmarkCompileMCPWorkflow - #48679
Merged
Conversation
The cache key `pr-${{ github.run_id }}` was rejected by the compiler's
cache-key validation (which disallows github.run_id in user-supplied keys
since the compiler appends it automatically). Updated to use
`pr-${{ env.GH_AW_WORKFLOW_ID_SANITIZED }}` which is the recommended pattern.
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix stale cache key in BenchmarkCompileMCPWorkflow
fix: update stale cache-key fixture in BenchmarkCompileMCPWorkflow
Jul 28, 2026
pelikhan
marked this pull request as ready for review
July 28, 2026 16:12
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the stale benchmark fixture to comply with cache-key validation and restore BenchmarkCompileMCPWorkflow, fixing #48676.
Changes:
- Replaces the prohibited
github.run_idexpression with the stable sanitized workflow ID.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/compiler_performance_benchmark_test.go |
Updates the MCP benchmark cache key fixture. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BenchmarkCompileMCPWorkflowwas failing because its test fixture usedgithub.run_iddirectly in acache-memorykey — now rejected by the compiler's cache-key validation, which disallowsrun_idin user-supplied keys since the compiler appends it automatically.Change
Updated the fixture's cache key in
compiler_performance_benchmark_test.go: