Report eval results in OpenTelemetry spans - #57166
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Answer normalization can produce telemetry inconsistent with persisted-result analysis.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds BinEval summaries and result events to eval-job OpenTelemetry conclusion spans while excluding question text.
Changes:
- Emits normalized eval counts and per-result events.
- Adds telemetry tests and a patch changeset.
- Reorders a workflow permission schema entry.
File summaries
| File | Description |
|---|---|
actions/setup/js/send_otlp_span.cjs |
Builds and attaches eval telemetry. |
actions/setup/js/send_otlp_span.test.cjs |
Tests telemetry content and job scoping. |
pkg/workflow/schemas/github-workflow.json |
Reorders a permission definition. |
.changeset/report-evals-otel.md |
Records the patch release note. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
@copilot this PR has open review feedback and the branch could use a refresh. Please address the latest review comments, update the branch with the latest base changes if needed, and run the Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Addressed the review feedback in 1f89c7e: eval answers now trim surrounding whitespace before normalization, with a padded-answer regression test. The branch is already current with |
|
@copilot this PR still has open review feedback and the branch could use a refresh. Please address the latest review comments, update the branch with the latest base changes if needed, and run the
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "github.com"See Network Configuration for more information.
|
Confirmed the linked review feedback is resolved, and the branch is current with |
BinEval results were persisted as artifacts but absent from OTLP telemetry, preventing direct evaluation analysis in observability backends.
gh-aw.evals.count,yes,no, andunknownattributes to eval-job conclusion spans.eval.resultevent with evaluation ID, normalized answer, and model.UNKNOWN.