Skip to content

Report eval results in OpenTelemetry spans - #57166

Merged
pelikhan merged 4 commits into
mainfrom
copilot/ensure-evals-results-reported
Aug 30, 2026
Merged

Report eval results in OpenTelemetry spans#57166
pelikhan merged 4 commits into
mainfrom
copilot/ensure-evals-results-reported

Conversation

Copilot AI commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

BinEval results were persisted as artifacts but absent from OTLP telemetry, preventing direct evaluation analysis in observability backends.

  • Summary metrics
    • Add gh-aw.evals.count, yes, no, and unknown attributes to eval-job conclusion spans.
  • Per-result events
    • Emit an eval.result event with evaluation ID, normalized answer, and model.
  • Data safety
    • Exclude free-form question text from telemetry.
    • Ignore malformed JSONL records and normalize unsupported answers to UNKNOWN.
  • Release
    • Add a patch changeset.

Copilot AI and others added 3 commits August 30, 2026 12:52
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI requested a review from pelikhan August 30, 2026 12:59
@pelikhan
pelikhan marked this pull request as ready for review August 30, 2026 12:59
Copilot AI balanced review requested due to automatic review settings August 30, 2026 12:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Answer normalization can produce telemetry inconsistent with persisted-result analysis.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds BinEval summaries and result events to eval-job OpenTelemetry conclusion spans while excluding question text.

Changes:

  • Emits normalized eval counts and per-result events.
  • Adds telemetry tests and a patch changeset.
  • Reorders a workflow permission schema entry.
File summaries
File Description
actions/setup/js/send_otlp_span.cjs Builds and attaches eval telemetry.
actions/setup/js/send_otlp_span.test.cjs Tests telemetry content and job scoping.
pkg/workflow/schemas/github-workflow.json Reorders a permission definition.
.changeset/report-evals-otel.md Records the patch release note.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread actions/setup/js/send_otlp_span.cjs Outdated
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot this PR has open review feedback and the branch could use a refresh. Please address the latest review comments, update the branch with the latest base changes if needed, and run the pr-finisher skill before handing back for maintainer review.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 13.2 AIC · ⌖ 8.63 AIC · ⊞ 9.2K ·
Comment /souschef to run again

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

@copilot this PR has open review feedback and the branch could use a refresh. Please address the latest review comments, update the branch with the latest base changes if needed, and run the `pr-finis...

Addressed the review feedback in 1f89c7e: eval answers now trim surrounding whitespace before normalization, with a padded-answer regression test. The branch is already current with main; completing the requested PR-finisher validation now.

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot this PR still has open review feedback and the branch could use a refresh. Please address the latest review comments, update the branch with the latest base changes if needed, and run the pr-finisher skill before handing back for maintainer review.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 11 AIC · ⌖ 8.63 AIC · ⊞ 9.2K ·
Comment /souschef to run again

Copilot AI commented Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

@copilot this PR still has open review feedback and the branch could use a refresh. Please address the latest review comments, update the branch with the latest base changes if needed, and run the `pr...

Confirmed the linked review feedback is resolved, and the branch is current with main (4 ahead, 0 behind). The referenced PR Sous Chef run completed successfully; its firewall notice is workflow-run telemetry, not an actionable change in this PR. Local format, lint, and unit validation pass.

@pelikhan
pelikhan merged commit bd6d3c6 into main Aug 30, 2026
43 checks passed
@pelikhan
pelikhan deleted the copilot/ensure-evals-results-reported branch August 30, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants