Accessibility updates to Main Nav and Table of Contents - #3718
Open
mlama007 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves navigation accessibility by aligning DOM and visual order and making the table of contents keyboard-operable.
Changes:
- Reorders guide navigation elements semantically.
- Replaces the TOC link with an accessible expandable button.
- Synchronizes TOC visual and ARIA states.
Show a summary per file
| File | Description |
|---|---|
assets/js/toc.js |
Updates aria-expanded with TOC state. |
assets/css/toc.scss |
Resets and sizes the new button. |
_layouts/article.html |
Adds semantic TOC button markup and ARIA relationships. |
_includes/nav.html |
Aligns navigation DOM order with visual order. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes fix some accessibility issues:
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.