Skip to content

Accessibility updates to Main Nav and Table of Contents - #3718

Open
mlama007 wants to merge 2 commits into
github:mainfrom
mlama007:accessibility-nav-TOC
Open

Accessibility updates to Main Nav and Table of Contents#3718
mlama007 wants to merge 2 commits into
github:mainfrom
mlama007:accessibility-nav-TOC

Conversation

@mlama007

@mlama007 mlama007 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

These changes fix some accessibility issues:

  1. Updates the semantic order of the main nav bar inside the guides so it matches the visual order going from: Open Source Guides > About > Contribute > Language. Currently, as you tab through the nav bar, it is our of order going from: About > Contribute > Language > Open Source Guides
  2. Updates the Table of content to a semantic expandable button that operable by keyboard and assistive technology. Currently, this is not keyboard operable.
  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Copilot AI review requested due to automatic review settings July 28, 2026 18:08
@mlama007
mlama007 requested a review from a team as a code owner July 28, 2026 18:08
@mlama007 mlama007 changed the title Accessibility nav toc Accessibility updates to Main Nav and Table of Contents Jul 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves navigation accessibility by aligning DOM and visual order and making the table of contents keyboard-operable.

Changes:

  • Reorders guide navigation elements semantically.
  • Replaces the TOC link with an accessible expandable button.
  • Synchronizes TOC visual and ARIA states.
Show a summary per file
File Description
assets/js/toc.js Updates aria-expanded with TOC state.
assets/css/toc.scss Resets and sizes the new button.
_layouts/article.html Adds semantic TOC button markup and ARIA relationships.
_includes/nav.html Aligns navigation DOM order with visual order.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Medium

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants