fix(presets): escape catalog metadata in discovery output - #3773
Open
marcelsafin wants to merge 1 commit into
Open
fix(presets): escape catalog metadata in discovery output#3773marcelsafin wants to merge 1 commit into
marcelsafin wants to merge 1 commit into
Conversation
Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Escapes preset catalog metadata so Rich renders bracketed values literally in discovery output.
Changes:
- Escapes catalog fields in
preset searchand catalog-backedpreset info. - Adds CLI regression tests covering each affected field.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/specify_cli/presets/_commands.py |
Escapes catalog-derived Rich output. |
tests/test_presets.py |
Verifies literal rendering of markup-like metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mnriem
requested changes
Jul 28, 2026
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please resolve conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preset catalog values such as names, IDs, versions, descriptions, authors,
repository URLs, and licenses were interpolated directly into Rich output by
preset searchand the catalog branch ofpreset info. Bracketed content wastherefore interpreted as markup instead of rendered literally.
This escapes those remaining catalog-derived fields with the module's existing
_escape_markuphelper. Tag shape validation and tag rendering are intentionallyleft to #3769, which already covers that separate crash path and overlapping tag
escape.
Regression tests assign distinct Rich tags to every field in scope and verify
literal rendering in both commands.
Testing
uv run specify --helpuv sync && uv run pytestFull suite: 5423 passed, 172 skipped.
AI Disclosure
GitHub Copilot (GPT-5.6 Sol) autonomously identified, implemented, tested, and
self-reviewed this change on behalf of @marcelsafin.