fix: bound response read in extension download command - #3776
Open
Quratulain-bilal wants to merge 1 commit into
Open
fix: bound response read in extension download command#3776Quratulain-bilal wants to merge 1 commit into
Quratulain-bilal wants to merge 1 commit into
Conversation
Replace unbounded response.read() with read_response_limited() in extensions/_commands.py to prevent DoS via oversized ZIP downloads from user-supplied URLs.
Contributor
There was a problem hiding this comment.
Pull request overview
Bounds ZIP downloads from custom extension URLs to mitigate memory-exhaustion attacks.
Changes:
- Imports the shared download-size limiter.
- Caps downloaded ZIP responses at 50 MiB.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/extensions/_commands.py |
Applies bounded reads to custom extension downloads. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Medium
| download_url, timeout=60, extra_headers=extra_headers | ||
| ) as response: | ||
| zip_data = response.read() | ||
| zip_data = read_response_limited(response, max_bytes=MAX_DOWNLOAD_BYTES) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace unbounded
esponse.read()\ with
ead_response_limited()\ in \extensions/_commands.py\ to prevent DoS via oversized ZIP downloads from user-supplied URLs.
Changes