Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions pointer.go
Original file line number Diff line number Diff line change
Expand Up @@ -694,6 +694,11 @@ func setSingleImpl(node, data any, decodedToken string, nameProvider NameProvide
return node, nil

case reflect.Map:
if rValue.IsNil() {
// a pointer to a nil map: assigning to it would panic
return node, fmt.Errorf("cannot set field %q on nil value: %w", decodedToken, ErrPointer)
}

kv, err := mapKeyValue(rValue.Type(), decodedToken)
if err != nil {
return node, err
Expand Down
20 changes: 20 additions & 0 deletions pointer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1501,3 +1501,23 @@ func TestSetMapValues(t *testing.T) {
require.Nil(t, value)
})
}

func TestSetPointerToNilMap(t *testing.T) {
t.Parallel()

p, err := New("/key")
require.NoError(t, err)

var document map[string]any

require.NotPanics(t, func() {
_, err = p.Set(&document, 1)
})
require.Error(t, err)
require.ErrorIs(t, err, ErrPointer)

require.NotPanics(t, func() {
_, err = SetForToken(&document, "key", 1)
})
require.Error(t, err)
}
Loading