Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
structFLS.Load skips a type-mismatched facet only for the first error it records: the continue for the type-mismatch case sits inside the
if err == nilguard, so once an earlier facet or field has set err, a later facet whose value type doesn't match the destination field falls through to reflect.Value.Set and panics (for example assigning an Atom to a float64 facet field). Facet data comes from the indexed document returned by the search backend, so loading a result whose facets don't line up with the destination struct crashes the request handler. Moved the continue out of the error guard so a mismatched facet is always skipped, matching the field loop and the other two facet checks in the same function, with the same change in v2 and a regression test.