Repository navigation
ci: pin GitHub Actions and restrict permissions - #94
Merged
Merged
Conversation
m4tx
added this pull request to stack #95
October 20, 2026 11:42
m4tx
marked this pull request as ready for review
October 20, 2026 11:45
qwandor
reviewed
Oct 20, 2026
|
|
||
| - name: Install cargo-hack | ||
| uses: taiki-e/install-action@cargo-hack | ||
| uses: taiki-e/install-action@cac6346340546319497bf24d4d54239150229f11 # cargo-hack |
Collaborator
There was a problem hiding this comment.
Does this work if cargo-hack is updated to a new version?
Collaborator
Author
There was a problem hiding this comment.
I looks like it does, as the action doesn't pin the version of cargo-hack, so it should always install the latest one: taiki-e/install-action@taiki-e:8cca091...taiki-e:cac6346
To be quite honest, specifying the tool to install via action commit sha sounds sort of like an anti-pattern anyway, so I've modified the change to use the "regular" install-action version and specify cargo-hack as an action parameter instead. Thanks for pointing this out!
qwandor
approved these changes
Oct 20, 2026
qwandor
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.