Repository navigation
OSS-Fuzz: Move fuzzers to upstream repository - #1343
Open
arthurscchan wants to merge 2 commits into
Open
arthurscchan wants to merge 2 commits into
arthurscchan wants to merge 2 commits into
Conversation
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces libFuzzer-based fuzz targets for the C API of libjsonnet, including CMake configuration updates and documentation. The feedback highlights a potential CMake configuration error when building fuzzers without other binary targets, and recommends adding an explicit compiler check for Clang to prevent build failures with other compilers. Additionally, the reviewer points out that setting *buf = NULL on import failure in the fuzzers violates the JsonnetImportCallback contract and suggests allocating a dummy error message using jsonnet_realloc to avoid undefined behavior or false-positive crashes.
- ImportCallback: return an allocated error message (via jsonnet_realloc) on failure, as required by the JsonnetImportCallback contract, instead of a NULL buffer. - CMake: build the jsonnet library targets when only BUILD_FUZZERS is enabled, so jsonnet_lib_for_binaries resolves. - CMake: fail with a clear error when the fuzzers are built without Clang. Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves all the OSS-Fuzz fuzzers to the upstream storage for easier management. This PR works together with OSS-Fuzz (google/oss-fuzz#16312) to accommodate the moving of fuzzers upstream.
Of course, this is only a suggestion. If the maintainers would prefer the fuzzers to remain in OSS-Fuzz, I am happy to keep the current setup and to ping the relevant maintainers for review whenever I add new fuzzers later in the process.
Thank you for considering this, and I would welcome any feedback on the preferred approach.
Remark: After this PR is accepted and merged, there will be additional PRs for adding new fuzzers for this project later.