Skip to content

fix: range-check the operand of bitwise not #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nussu06 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: range-check the operand of bitwise not #1349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/vm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3246,7 +3246,8 @@ class Interpreter {
case UOP_MINUS: scratch = makeNumber(-scratch.v.d); break;

case UOP_BITWISE_NOT:
scratch = makeNumber(~(long)(scratch.v.d));
scratch = makeNumber(
~safeDoubleToInt64(scratch.v.d, ast.location));
break;

default:
Expand Down
3 changes: 3 additions & 0 deletions test_suite/error.integer_bitwise_not.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
// Value just beyond MAX_SAFE_INTEGER (2^53 - 1)
local beyond_max = 9007199254740992; // 2^53
~beyond_max // Should throw error "numeric value outside safe integer range for bitwise operation"
2 changes: 2 additions & 0 deletions test_suite/error.integer_bitwise_not.jsonnet.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
RUNTIME ERROR: numeric value outside safe integer range for bitwise operation.
error.integer_bitwise_not.jsonnet:3:1-12
Loading