Keep '#' in unquoted CLI values instead of treating it as a comment - #691
Open
DSeaStar wants to merge 1 commit into
Open
Keep '#' in unquoted CLI values instead of treating it as a comment#691DSeaStar wants to merge 1 commit into
DSeaStar wants to merge 1 commit into
Conversation
ast.parse strips '#...' as a Python comment, so values like hi#there were silently truncated. If tokenize sees a comment token, keep the original string so hashes and fragments survive (issue google#338).
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #338.
DefaultParseValueparses CLI args withast.parse, which treats#as the start of a Python comment. Unquoted values were therefore truncated:That is an unintended side effect of using the AST (as noted on the issue). The existing parser test even called the strip "behavior [that] may change in the future."
If tokenize sees a
#comment token (i.e. the hash is not inside a string literal), keep the original string. Quoted forms such as"0#comments"still parse as the string0#comments.Test plan
pytest fire/parser_test.py(20 passed)hi#there,path#ref, and0#comments