Repository navigation
Allow device-only CSV inventories without optional attributes - #22
Open
vinsymoyya wants to merge 1 commit into
Open
vinsymoyya wants to merge 1 commit into
vinsymoyya wants to merge 1 commit into
Conversation
Contributor
|
Thanks for submitting the fix. We probably don't need a dedicated file for this unittest - can you add it to inventory_csv_test.py instead (maybe after the Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow CSV inventories containing only the mandatory
devicecolumn. After removing that column from the attribute header, the parser indexed the empty header list while checking for optional flags and raisedIndexErroron the first device row.Guard the optional-header lookup. Device names now map to valid empty attribute tuples, while ordinary attributes and variable-length flags retain their behavior.
Fixes #21.
Validation on Linux / Python 3.13:
f15c05543241e5faa482d0fae0c2244d456091b7); three controls pass.git diff --checkpasses. A whole-file source check also proposes formatting changes outside this patch.