Repository navigation
Restore shared state after test fixtures #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vinsymoyya
wants to merge
1
commit into
google:master
Choose a base branch
from
vinsymoyya:fix/restore-test-fixture-state
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| # Copyright 2026 Google Inc. All Rights Reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
| # implied. See the License for the specific language governing | ||
| # permissions and limitations under the License. | ||
| """Ensure test fixtures release their process-wide state after cleanup.""" | ||
|
|
||
| import subprocess | ||
| import sys | ||
| import unittest | ||
|
|
||
| _PROBE = r""" | ||
| import importlib | ||
| import sys | ||
| import threading | ||
| from absl import flags | ||
| from tcli import accessor_base, command_response, inventory_base, tcli_lib | ||
|
|
||
| module_name, class_name = { | ||
| 'response': ('tcli.command_response_test', 'UnitTestCmdResponse'), | ||
| 'inventory': ('tcli.inventory_base_test', 'InventoryBaseTest'), | ||
| 'tcli': ('tcli.tcli_test', 'UnitTestTCLI'), | ||
| 'end_to_end': ('tcli.end_to_end_test', 'UnitTestTCLIEndToEnd'), | ||
| }[sys.argv[1]] | ||
| original = { | ||
| 'lock': threading.Lock, | ||
| 'event': threading.Event, | ||
| 'fetch': inventory_base.Inventory._FetchDevices, | ||
| 'send': accessor_base.SendRequests, | ||
| 'tqdm': command_response.tqdm, | ||
| 'flags': flags.FLAGS, | ||
| 'inventory_module': tcli_lib.inventory, | ||
| 'accessor_module': tcli_lib.accessor, | ||
| } | ||
| flag_values = { | ||
| name: flags.FLAGS[name].value | ||
| for name in ('template_dir', 'color', 'config_file', 'display', 'filter') | ||
| if name in flags.FLAGS | ||
| } | ||
| fixture = getattr(importlib.import_module(module_name), class_name) | ||
| fixture.setUpClass() | ||
| try: | ||
| case = fixture() | ||
| try: | ||
| case.setUp() | ||
| if getattr(case, 'inv', None) is not None: | ||
| assert case.inv._loaded.wait(2), 'Inventory did not finish loading' | ||
| case.tearDown() | ||
| finally: | ||
| case.doCleanups() | ||
| finally: | ||
| try: | ||
| fixture.tearDownClass() | ||
| finally: | ||
| fixture.doClassCleanups() | ||
|
|
||
| leaks = [] | ||
| for name, actual in { | ||
| 'lock': threading.Lock, | ||
| 'event': threading.Event, | ||
| 'fetch': inventory_base.Inventory._FetchDevices, | ||
| 'send': accessor_base.SendRequests, | ||
| 'tqdm': command_response.tqdm, | ||
| 'flags': tcli_lib.FLAGS, | ||
| 'inventory_module': tcli_lib.inventory, | ||
| 'accessor_module': tcli_lib.accessor, | ||
| }.items(): | ||
| if actual is not original[name]: | ||
| leaks.append(name) | ||
| for name, value in flag_values.items(): | ||
| if flags.FLAGS[name].value != value: | ||
| leaks.append('flag value: ' + name) | ||
| assert not leaks, 'Fixture leaked process state: ' + ', '.join(leaks) | ||
|
|
||
| # An unrelated caller can still use the real synchronization primitives. | ||
| event = threading.Event() | ||
| worker = threading.Thread(target=event.set) | ||
| worker.start() | ||
| worker.join(2) | ||
| assert not worker.is_alive() and event.is_set() | ||
| """ | ||
|
|
||
|
|
||
| class FixtureIsolationTest(unittest.TestCase): | ||
|
|
||
| def assertFixtureIsolated(self, name): | ||
| result = subprocess.run( | ||
| [sys.executable, '-c', _PROBE, name], | ||
| capture_output=True, | ||
| text=True, | ||
| timeout=60, | ||
| check=False, | ||
| ) | ||
| self.assertEqual(0, result.returncode, result.stdout + result.stderr) | ||
|
|
||
| def testCommandResponseFixture(self): | ||
| self.assertFixtureIsolated('response') | ||
|
|
||
| def testInventoryFixture(self): | ||
| self.assertFixtureIsolated('inventory') | ||
|
|
||
| def testTcliFixture(self): | ||
| self.assertFixtureIsolated('tcli') | ||
|
|
||
| def testEndToEndFixture(self): | ||
| self.assertFixtureIsolated('end_to_end') | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| unittest.main() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is pretty involved and I'd rather avoid a subprocess if possible.
Either move the probe into a module or consider using
pytest -p randomly