Repository navigation
Conversation
…ests These tests switch queue.default to the database connection and restart the app, disabling only the app's own queue runners. The framework's goravel:queue runner then starts too and consumes the same queue concurrently with the test's worker (or before readQueuedNotificationItem reads the job), so the job row can still exist when the test counts it, or be gone when it reads it. Disable goravel:queue like the other notification, broadcast and multi-queue tests already do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Closes goravel/goravel#1020
The queued notification tests switch
queue.defaulttodatabaseand restart the app. They disable only the app's own queue runners, so the framework'sgoravel:queuerunner starts as well and consumes the same queue concurrently with the test's worker. That makesTestSendQueuedNotificationRetriesTransientFailureintermittently find the job still injobs(expected: 0, actual: 1), and the same race can affect the tests that read the queued payload.This disables
goravel:queuein the six affected tests, like the other notification, broadcast and multi-queue tests already do.Verification:
attempts = 1), which shows the hidden consumer. With this change it wasn't (attempts = 0).TestNotificationTestSuitepasses repeatedly against framework master.✅ Checks