Repository navigation
Conversation
Contributor
|
Preview is ready. |
korvin89
reviewed
Oct 16, 2026
korvin89
left a comment
korvin89
left a comment
Contributor
There was a problem hiding this comment.
🤖 AI generated
This review was done with AI assistance. I validated every comment myself, but the wording — including the points I found myself — was written by the AI.
Severity legend
- 🔴 blocker — should be fixed before merge.
- 🟠 should-fix — a real problem; worth fixing before or right after merge. If you can't get to it now, please open an issue and leave a comment linking it.
- 🔵 nit — minor; author's discretion.
- ❓ question — I need more context; not necessarily a defect.
Findings outside the diff
README.md:34— 🟠 should-fix — The removal ofAdaptiveTabsis a breaking change, but the migration guide does not mention it: this PR only drops the existingAdaptiveTabsbullet from the "Migrating to UIKit 8" list. Consumers whoseimport {AdaptiveTabs} from '@gravity-ui/components'breaks after the upgrade will not find the reason or the migration path in the README. Please add a bullet to this list stating thatAdaptiveTabsis removed and what to use instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.