Skip to content

feat(QueryPage): confirm history query deletion - #94

Merged
SimbiozizV merged 1 commit into
mainfrom
feat/query-delete-confirmation
Oct 19, 2026
Merged

SimbiozizV merged 1 commit into
mainfrom
feat/query-delete-confirmation

Conversation

@SimbiozizV

Copy link
Copy Markdown
Collaborator

The default QueryPage history Delete action now opens a confirmation dialog with the query name and an irreversible-deletion warning. The page calls onDelete only after confirmation; canceling or closing the dialog leaves the query unchanged. Pending confirmation is cleared when its history tab or delete callback disappears. Custom row actions retain their existing behavior.

Includes English/Russian translations, documentation, and tests covering confirmation, cancellation, row ID zero, originating tabs, and invalidated pending actions.

Validation:

  • QueryPageHistoryActions: 13 tests passed.
  • TypeScript tsc --noEmit passed.
  • ESLint: no errors; three non-null assertion warnings in the test file.
  • git diff --check passed.
  • npm run build completed with exit code 0; emitted tsconfig-paths warnings about missing baseUrl.
  • Browser interaction and focus behavior were not verified.

@gravity-ui-bot

Copy link
Copy Markdown
Contributor

Preview is ready.

@SimbiozizV
SimbiozizV merged commit 239dc10 into main Oct 19, 2026
3 checks passed
@SimbiozizV
SimbiozizV deleted the feat/query-delete-confirmation branch October 19, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants