Repository navigation
feat(QueryPage): confirm history query deletion - #94
Merged
Merged
Conversation
Contributor
|
Preview is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default QueryPage history Delete action now opens a confirmation dialog with the query name and an irreversible-deletion warning. The page calls
onDeleteonly after confirmation; canceling or closing the dialog leaves the query unchanged. Pending confirmation is cleared when its history tab or delete callback disappears. Custom row actions retain their existing behavior.Includes English/Russian translations, documentation, and tests covering confirmation, cancellation, row ID zero, originating tabs, and invalidated pending actions.
Validation:
tsc --noEmitpassed.git diff --checkpassed.npm run buildcompleted with exit code 0; emitted tsconfig-paths warnings about missingbaseUrl.