Repository navigation
better support for sourcePath - #1
Merged
Merged
Conversation
sourcePath in the original is strange. It kind of looks like it's designed to be mutually exclusive with analyzeModifiedFilesOnly (as I type this, I see that's documented under analyzeModifiedFilesOnly, but not under sourcePath) This change allows sourcePath and analyzeModifiedFilesOnly to work together. It might be brittle but it works for our use case
There was a problem hiding this comment.
🟡 Changes recommended
Path prefixing and default sourcePath handling cause incorrect file filtering.
2 open issues
What changed in this PR
Updates modified-file handling to support sourcePath with analyzeModifiedFilesOnly.
Changes:
- Normalizes source paths.
- Prefixes and filters modified filenames.
| File | Summary |
|---|---|
src/util.ts |
Adjusts modified-file extraction and source-path filtering. |
Review effort: Lite
| // add trailing slash | ||
| sourcePath = | ||
| sourcePath !== '.' ? path.normalize(`${sourcePath}/`) : sourcePath | ||
| sourcePath = path.normalize(`${sourcePath}/`) |
Comment on lines
+366
to
367
| .map(f => sourcePath + f) | ||
| .filter(f => sourcePath === '.' || f.startsWith(sourcePath)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sourcePath in the original is strange. It kind of looks like it's designed to be mutually exclusive with analyzeModifiedFilesOnly (as I type this, I see that's documented under analyzeModifiedFilesOnly, but not under sourcePath)
This change allows sourcePath and analyzeModifiedFilesOnly to work together. It might be brittle but it works for our use case