fix: detach resize-handle document listeners on destroy before move threshold - #3346
Open
patrykskrzyniarz wants to merge 1 commit into
Open
Conversation
…hreshold DDResizableHandle.destroy() only called _mouseUp when moving was true, so a handle torn down between mousedown and the 3px threshold left document mousemove/mouseup listeners attached and threw on every subsequent mouse event. Guard on mouseDownEvent instead, matching DDDraggable.destroy(). Fixes gridstack#3345 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DDResizableHandle.destroy(): documentmousemove/mouseuplisteners attached onmousedownwere only removed whenthis.movingwas true (after the 3px threshold).mousedownand that threshold left orphaned listeners that then threwCannot read properties of undefined (reading 'gridstackNode')on every subsequent mouse event until reload.this.mouseDownEventinstead — same pattern asDDDraggable.destroy().Fixes #3345
Test plan
mousedownon a.ui-resizable-handlewithout moving >3px, then callremoveAll()/disable()/destroy()while still heldgridstackNodeTypeError, no repeating errors on later mouse eventsMade with Cursor