feat: add --json output to netwp events - #85
Merged
Conversation
events was text-only, unlike scan/doctor/ports/speedtest. Add --json so the event history is scriptable: it prints the []eventlog.Entry as a JSON array (the Entry type already carries JSON tags, so no separate DTO). An empty history emits [] rather than null, via eventsForJSON, so the output is always valid JSON. Closes #71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
netwp eventswas text-only, unlikescan/doctor/ports/speedtest. This adds--jsonso the join/leave history is scriptable.[]eventlog.Entryas a JSON array;eventlog.Entryalready carries JSON tags (kind/ip/mac/name/at), so no separate DTO.[], nevernull(eventsForJSONguards the nil slice), so the output is always valid JSON.--devicetoo.Closes #71
Risks
None. Additive read-only flag; the default text output is unchanged.
Checklist
TestEventsForJSON)README.mdandREADME.pt-BR.mdupdated in this PR