feat: add scan --sort=<column> for non-interactive sorting - #87
Merged
Conversation
monitor/dashboard could sort the device table with `s`, but a one-shot scan always came out in IP order. Add --sort=ip|rtt|name|class, reusing the live views' comparator so both order identically. An unknown column fails fast, before scanning, mirroring --class. Sorting moves from RenderDevices to the caller: the renderer now prints what it is given, so the same path serves the table and --json (which previously came out unordered). The default is still IP, and the shared comparator keeps online devices first. Closes #73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
monitor/dashboardcan sort the device table interactively withs; a one-shotscanalways came out in IP order. This adds--sort=ip|rtt|name|class.lessByKey), so--sort=rttand the interactivesorder identically.SortKeyis now exported with aParseSortColumnfor the CLI.--class):scan --sort=boguserrors in ~35ms.RenderDevicesto the caller. The renderer now prints what it is given, so one path serves both the table and--json— which previously came out unordered. Default is still IP, and the shared comparator keeps online devices first.Verified live: default order unchanged (
.1, .20, .27, .88, .138, .178),--sort=rttreorders, bad column fails fast.Closes #73
Risks
None security-wise. Behavioral note:
scan --jsonoutput is now ordered (it wasn't before) and offline devices sort after online ones — in practice a scan only returns online devices, so the visible table order is unchanged.Checklist
TestParseSortColumn,TestSortDevicesScanByRTT,TestSortDevicesOnlineFirstAndByIP)README.mdandREADME.pt-BR.mdupdated in this PR