Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #448. Keep this draft until that correctness fix lands, then rebase. The lifecycle-only changes can be reviewed here: mickeyl/esp-nimble-cpp@25a9994...8bba853
Concurrent writers, early credit completions and disconnect/deinit can leave send waiters or callback work referring to an old connection. Serialize whole writes, submit native operations on the host, retain completion state across early notifications, abort incomplete writes and drain pending work before channel reuse/destruction. Reclaim the shared callback worker/queue after the last channel, and delete the CoC server before the native NPL runtime is released.
The pool now allocates configurable full-SDU buffers, including mbuf and packet-header headroom. This changes memory use: five buffers by default, rather than subdividing about three MTUs into 250-byte blocks.
Observable callback contract:
Validation:
The host-task policy overlaps conceptually with #419 and should be coordinated during review. HCI resource windows, private header diagnostics, MPS alignment and the standalone measurement harness are outside this PR. Earlier hardware measurements informed the design; they are not presented as RF acceptance of every extracted commit.
The native host-event test shim now enqueues outside assert(), so disabling assertions does not disable its scheduling. This fixture change is separate from the production lifecycle behavior.