RDF ShExGenerator R6 fixes -- FHIR-53178 - #2491
Draft
tmprd wants to merge 30 commits into
Draft
Conversation
Rebase of "Changes in ShEx for R6" on master
Eric p rebased master 2025 10 30
e.g. "contentReference" : "#Resouce1.element3"
``` shex
<ArtifactAssessment.content.componentnull> CLOSED {
}
```
…cept when redundant with upstream refactor
… upstream refactor
tmprd
changed the title
Contributor
Author
|
Comparison from same set of StructureDefinitions New R6 ShExOld R6 ShEx from current
|
Contributor
Author
|
xhtml and SimpleQuantity are the only core profiles with a max 0 cardinality constraint, which are now corrected to this: <SimpleQuantity> EXTENDS @<Quantity> CLOSED {
a [fhir:SimpleQuantity]?;
fhir:comparator . {0}
}
<Xhtml> EXTENDS @<PrimitiveType> CLOSED {
fhir:v rdf:XMLLiteral;
fhir:extension . {0};
} |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2491 +/- ##
==============================================
+ Coverage 8.55% 8.57% +0.02%
- Complexity 41051 41205 +154
==============================================
Files 3411 3417 +6
Lines 1255084 1255850 +766
Branches 373380 373554 +174
==============================================
+ Hits 107377 107716 +339
+ Misses 1111707 1111574 -133
- Partials 36000 36560 +560 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🕊️ In memory of Detlef Grittner https://trauer.nn.de/traueranzeige/detlef-grittner
Applies fixes from @detlef-grittner-sohard and @ericprud after recent ShExGenerator cross-version refactor in #2230
Bug fixes for https://jira.hl7.org/browse/FHIR-53178
Minor fixes
?in constraintsfhir:llinks are optionalrdf:typefor choice type elements needed for disambiguation (names like valueQuantity aren't used)<PlanDefinition.action.actionnull>, see ShEx content references w3c-cg/hcls-fhir-rdf#243<Resource>to long "OR" list of<Resource>shapes(NOT { fhir:nodeRole [fhir:treeRoot] ; a [fhir:Resource] } OR @<Resource>) ORto long list of<All>shapes