Skip to content

SRE-1236: Update Brunch Docker images to Node.js 22.23.4 - #461

Merged
indietyp merged 1 commit into
mainfrom
bm/sre-1236-update-docker-nodejs-runtimes-and-remove-temporary-ca
Oct 22, 2026
Merged

indietyp merged 1 commit into
mainfrom
bm/sre-1236-update-docker-nodejs-runtimes-and-remove-temporary-ca

Conversation

@indietyp

@indietyp indietyp commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

🌟 Purpose

Pin Brunch's Docker build and runtime to Node.js 22.23.4 and restore Node's default certificate store. Keep the OS CA-package requirement unchanged.

⚠️ Known issues

  • Breaking: Node.js no longer trusts private CAs installed only in the OS store. Supply them through NODE_EXTRA_CA_CERTS or the client's ca option.
  • The Dockerfile copies an absent server/ directory. Update its server copy and startup paths before building the application image.

Stack created with GitHub Stacks CLI • Give Feedback 💬

@indietyp
indietyp force-pushed the bm/sre-1236-update-docker-nodejs-runtimes-and-remove-temporary-ca branch from 612d47a to bf8845f Compare October 21, 2026 19:26
@indietyp indietyp changed the title fix: pin node version SRE-1236: Update Brunch Docker images to Node.js 22.23.4 Oct 21, 2026
@indietyp
indietyp marked this pull request as ready for review October 21, 2026 19:29
@cursor

cursor Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
TLS trust behavior changes in the container: workloads that relied on OS-only private CAs via --use-openssl-ca must use NODE_EXTRA_CA_CERTS or client ca options instead.

Overview
Pins the Brunch Docker base image from node:22-bookworm-slim to node:22.23.4-bookworm-slim for reproducible build and runtime Node versions.

Removes NODE_OPTIONS=--use-openssl-ca and its comment so Node uses its default certificate store again instead of forcing the system OpenSSL trust store. The existing ca-certificates apt install and minimum version check are unchanged.

Reviewed by Cursor Bugbot for commit bf8845f. Bugbot is set up for automated code reviews on this repo. Configure here.

@indietyp
indietyp added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 446e3c8 Oct 22, 2026
11 of 12 checks passed
@indietyp
indietyp deleted the bm/sre-1236-update-docker-nodejs-runtimes-and-remove-temporary-ca branch October 22, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants