Repository navigation
FE-2016: Show when the file preview's match-case button is on - #10086
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
b8ff806 to
f42182d
Compare
PR SummaryLow Risk Overview The file preview match-case control already sets Reviewed by Cursor Bugbot for commit 8a35b70. Bugbot is set up for automated code reviews on this repo. Configure here. |
f42182d to
c8175ca
Compare
c8175ca to
087cf3b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8a35b70. Configure here.

🌟 Purpose
The file preview's match-case button looked almost the same on and off, because only its icon turned blue. While it is on, it now has a
blue[20]background and ablue[30]border. Closes FE-2016 (internal).Before, with match case on

After, with match case on

🔍 Changes
GrayToBlueIconButtonstyles itself fromaria-pressed, which only the match-case button sets. Against white, the new background is 1.13:1 and the border 1.38:1, about the same as the new design system's pressedghost/brandButton(1.09:1 and 1.32:1).🧪 Testing
lint:tsc, ESLint andoxfmt --checkpass. I checked the PDF preview in Chromium.