Repository navigation
FE-2028: Make Petrinaut's Actual Mode independent of what feeds it - #10121
kostandinang merged 4 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
PR SummaryMedium Risk Overview The petrinaut-website Brunch Actual Mode demo is deleted: User-facing and core README/docs describe host-supplied execution generically rather than Brunch/SSE. Reviewed by Cursor Bugbot for commit 4ec55b0. Bugbot is set up for automated code reviews on this repo. Configure here. |
CiaranMn
left a comment
There was a problem hiding this comment.
My main suggestion is to get rid of more code to cut down on future maintenance burden – any reason to keep the old-Brunch SSE stuff around in petrinaut-website?
Kept it on purpose as a reference host for now, since it's the only way to try Actual Mode by hand until flow runs can be shown there (noted under Known issues in the description). Planned deleting in follow-up once that lands, but happy to delete it in this PR too. |
…ding version 1 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Done in 4ec55b0: removed /brunch, the brunch-demo adapter and the fixture script |
🌟 Purpose
Petrinaut's Actual Mode still names its only host.
ActualModeSourceis{ kind: "brunch"; endpoint; runId? }, the shared context carries Brunch's raw SSE events so the Events tab can export them, and the docs and AI context describe Brunch. A flow run can't be a source without pretending to be Brunch.This PR makes the interface generic without changing how Actual Mode works. The host still supplies the net, the initial marking and the transition firings, in the same shapes. Only the source changes, the raw stream export goes, and so does the website's Brunch Actual Mode route, which nothing produces a stream for any more.
🔍 Changes
ActualModeSourceis now{ id: string; label?: string }, and Petrinaut treats both as opaque. A newidstarts a new timeline, andlabelis kept in recordings. The execution frame'ssourceIdis built fromid.receivedEventsleaves the shared context, along with the raw events recording type and helper./brunchroute, its stream adapter insrc/main/app/brunch-demo/, and theyarn brunch:fixturescript are removed, with their README section and arch-docs mentions. The website's Brunch AI assistant is untouched.brunchDemoModein the user settings provider is left too, since it's dropped the next time settings are saved.PetrinautPreview, places inside subnet instances, coloured tokens, and the O(n²) marking replay.🛡 Tests
sourceId, and in the Events tab.@hashintel/petrinaut-core,@hashintel/petrinautand@apps/petrinaut-website.libs/@hashintel/petrinautandlibs/@hashintel/petrinaut-corefor brunch, sse and EventSource (any case) only finds AI assistant code and docs,brunchDemoModeand its tests, and an example plugin id in a comment.