Fix: Filter out private internal libraries from package pages - #1437
Merged
Conversation
Co-authored-by: nikita-volkov <1560937+nikita-volkov@users.noreply.github.com>
Co-authored-by: nikita-volkov <1560937+nikita-volkov@users.noreply.github.com>
…-visibility Fix: Filter out private internal libraries from package pages
This was referenced Oct 10, 2025
Bodigrim
reviewed
Oct 10, 2025
visibility can be a part of CondTree, e. g.,
```haskell
library foo-internal
if flag(foo)
visibility: public
else
visibility: private
```
See haskell#1437 (comment)
Member
|
Have you tested this with puresat? Or do you want me to test it? |
Contributor
Author
Please test it :) |
Member
|
seems to work, the internal libraries are no longer shown: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the bug described in #1346.
Should be noted that the patch is generated with AI.