Repository navigation
feat(tracker): create a milestone from the milestone selector - #11137
MichaelUray wants to merge 1 commit into
Conversation
The milestone selector used when creating or editing an issue only listed existing milestones, so a milestone that did not exist yet could not be added without leaving the issue dialog. NewMilestone also did not report the created milestone back to its caller. The selector now offers a "New Milestone" entry when it is bound to a single project. It opens the existing NewMilestone dialog for that project and selects the created milestone afterwards (only if it was created in the same project, since the dialog allows changing the project). NewMilestone now passes the id of the created milestone when it closes. Fixes hcengineering#4858 Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
acea7cf to
5a92263
Compare
|
@MichaelUray Please take a look at failed formatting: What do you think about this suggestion? |
|
@ArtyomSavchenko Thanks for checking this. I investigated the latest CI run on The build checks out the moving PR merge ref, while formatting checks out the event’s original merge SHA. The build cache includes source files, so restoring it overlays newer develop changes onto the older checkout:
I’m preparing a separate workflow-fix PR to pin the checkouts to I’ve addressed the milestone permission suggestion with |
Fixes #4858
Problem and change
The milestone selector used when creating or editing an issue only listed existing milestones, so a milestone that did not exist yet could not be added without leaving the issue dialog. NewMilestone also did not report the created milestone back to its caller.
The selector now offers a "New Milestone" entry when it is bound to a single project. It opens the existing NewMilestone dialog for that project and selects the created milestone afterwards (only if it was created in the same project, since the dialog allows changing the project). NewMilestone now passes the id of the created milestone when it closes.
Tests
No unit test (popup wiring). Checked manually on a self-hosted instance: in the New issue dialog the milestone selector lists "New Milestone" after "No milestone"; it opens the milestone dialog for the current project and the created milestone is selected; the same works on an existing issue's milestone field; the bulk context-menu action does not offer it.