Repository navigation
fix(i18n): check every UI language in the locale consistency tests - #11151
Open
MichaelUray wants to merge 1 commit into
Open
MichaelUray wants to merge 1 commit into
MichaelUray wants to merge 1 commit into
Conversation
makeLocalesTest compared only ru against en, so keys missing from (or left over in) the other twelve shipped languages went unnoticed: about 3000 strings were missing across the asset packages, a few keys had been translated by name or misspelled, and desktop-preferences had no Italian file at all. makeLocalesTest now checks all languages the front end offers and names the failing language. A package can pass languages that are known to be incomplete as a skip list; this is used only where the gap is too large to close here (tracker: 10 languages, controlled-documents: pt/pt-br, billing: ko, github: no ja file). The remaining small gaps are closed: missing strings translated, stale keys removed, misnamed keys renamed (task pt/pt-br, process pt/pt-br/de, core cs/it, billing cs, communication, login cs) and the German beta warning moved to the key that is actually used. Fixes hcengineering#5048 Signed-off-by: Michael Uray <michaeluray@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5048
Problem and change
makeLocalesTest compared only ru against en, so keys missing from (or
left over in) the other twelve shipped languages went unnoticed: about
3000 strings were missing across the asset packages, a few keys had
been translated by name or misspelled, and desktop-preferences had no
Italian file at all.
makeLocalesTest now checks all languages the front end offers and
names the failing language. A package can pass languages that are
known to be incomplete as a skip list; this is used only where the gap
is too large to close here (tracker: 10 languages, controlled-documents:
pt/pt-br, billing: ko, github: no ja file).
The remaining small gaps are closed: missing strings translated,
stale keys removed, misnamed keys renamed (task pt/pt-br, process
pt/pt-br/de, core cs/it, billing cs, communication, login cs) and the
German beta warning moved to the key that is actually used.
Tests
makeLocalesTestnow checks all 14 languages; ran all 61lang.test.tssuites: 61/61 pass. Removing a skip entry makes the corresponding suite fail, so the check is effective.Notes