Repository navigation
Report a HED key nested beside a valid one in a sidecar entry - #976
Merged
Merged
Conversation
Move the hed-tests pin to babc444, which adds the case sidecar-invalid-hed-key-nested-beside-valid, and add unit tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change tightening nested HED-key validation.
No open issues 🎉
What changed in this PR
This PR tightens sidecar validation to reject nested HED keys in sibling metadata, even when the entry contains a valid second-level HED key.
Changes:
- Check sibling values for illegally nested HED keys before accepting an entry.
- Add tests for two invalid nesting depths and valid sibling metadata without HED keys.
| File | Description |
|---|---|
tests/otherTests/issueParameters.spec.js |
Tests nested-key rejection, error parameters, and valid sibling metadata. |
src/bids/types/json.js |
Checks sibling metadata for deep HED keys alongside a valid HED key. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the hed-tests pin to babc444, which adds the case sidecar-invalid-hed-key-nested-beside-valid, and add unit tests.