Skip to content

Report a HED key nested beside a valid one in a sidecar entry - #976

Merged
VisLab merged 1 commit into
hed-standard:mainfrom
VisLab:fix_required
Nov 10, 2026
Merged

VisLab merged 1 commit into
hed-standard:mainfrom
VisLab:fix_required

Conversation

@VisLab

@VisLab VisLab commented Nov 10, 2026

Copy link
Copy Markdown
Member

Move the hed-tests pin to babc444, which adds the case sidecar-invalid-hed-key-nested-beside-valid, and add unit tests.

Move the hed-tests pin to babc444, which adds the case
sidecar-invalid-hed-key-nested-beside-valid, and add unit tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the change tightening nested HED-key validation.

No open issues 🎉

What changed in this PR

This PR tightens sidecar validation to reject nested HED keys in sibling metadata, even when the entry contains a valid second-level HED key.

Changes:

  • Check sibling values for illegally nested HED keys before accepting an entry.
  • Add tests for two invalid nesting depths and valid sibling metadata without HED keys.
File Description
tests/​otherTests/​issueParameters.spec.js Tests nested-key rejection, error parameters, and valid sibling metadata.
src/​bids/​types/​json.js Checks sibling metadata for deep HED keys alongside a valid HED key.

Review effort: Balanced

@VisLab
VisLab merged commit bf7c881 into hed-standard:main Nov 10, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants