You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix the false negatives in review items 8.1.1-8.1.7:
- misnested parentheses are PARENTHESES_MISMATCH
- a placeholder that is not the whole value is PLACEHOLDER_INVALID
- curly-brace column names may contain any character
- a definition beside other tags in a sidecar entry is
DEFINITION_INVALID
- a HED key nested in a sidecar column is SIDECAR_INVALID
- units in a Def value are checked against the definition
- sidecar strings that reference {HED} skip combination checks
df_to_hed no longer adds a Description tag beside definitions.
Pin hed-tests babc444 and hed-examples de5c4b0.
This PR addresses missed validation errors in hedtools and adjusts sidecar handling to distinguish standalone checks from checks that require assembled rows.
- A brace name with a comma or parenthesis is not a column
reference, since a reference must parse as one tag.
- Escape the reference in replace_ref's removal regex, so
{my.col} and {col+1} remove only themselves.
- df_to_hed detects Definition tags, not any "definition/"
substring, before leaving out the Description tag.
Preserve hash-containing references during value substitution
hed/models/model_constants.py:10
This now accepts # in a column name, but ColumnMapper._value_handler() replaces every # in the whole template before reference substitution. For the valid value template Label/#, {col#1} and cell 3, it produces Label/3, {col31}; subsequent substitution of {col#1} cannot find the reference, so assembly leaves invalid braces and loses the referenced annotation. Preserve curly-brace references while filling value placeholders, and add an assembly regression case for a hash-containing column name.
- Detect Definition tags with a library prefix and only at a
tag boundary, so df_to_hed keeps Description tags on
values that merely mention a definition.
- Leave "#" inside curly-brace references alone when filling
a value placeholder, so {col#1} is still substituted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the false negatives in review items 8.1.1-8.1.7:
df_to_hed no longer adds a Description tag beside definitions. Pin hed-tests babc444 and hed-examples de5c4b0.