Skip to content

Update reserved_tags.json and the hed-tests submodule - #1503

Merged
VisLab merged 1 commit into
hed-standard:mainfrom
VisLab:address_issues
Nov 17, 2026
Merged

VisLab merged 1 commit into
hed-standard:mainfrom
VisLab:address_issues

Conversation

@VisLab

@VisLab VisLab commented Nov 17, 2026

Copy link
Copy Markdown
Member

Copy reserved_tags.json unchanged from hed-specification (description now points to Appendix B.3) and move spec_tests/hed-tests to fe7eab6.

Copy reserved_tags.json unchanged from hed-specification (description
now points to Appendix B.3) and move spec_tests/hed-tests to fe7eab6.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@VisLab
VisLab requested a balanced review from Copilot November 17, 2026 11:08
@VisLab VisLab added dependencies Pull requests that update a dependency file testing maintenance required-update labels Nov 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The hed-tests gitlink change is absent from the supplied diff and the local submodule is empty, so integration and fixture compatibility still require confirmation from initialized-submodule CI.

No open issues 🎉

What changed in this PR

Refreshes upstream HED specification metadata and test fixtures. The reviewed JSON change updates documentation without changing validation behavior.

Changes:

  • Replaces the description's earlier-schema explanation with a reference to Appendix B.3.
  • Leaves structured validation rules and version fields unchanged.
  • The PR description also records a hed-tests submodule update to fe7eab6; that change was not included in the supplied diff.
File Description
hed/​validator/​data/​reserved_tags.json Updates descriptive metadata to reference Appendix B.3 for earlier-schema differences.

Review effort: Balanced

@VisLab
VisLab merged commit 505e918 into hed-standard:main Nov 17, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file maintenance required-update testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants