Repository navigation
[RES-1463] Fix the JMeter integration test - #410
Closed
etiennechabert wants to merge 3 commits into
Closed
etiennechabert wants to merge 3 commits into
etiennechabert wants to merge 3 commits into
Conversation
The test deletes its namespace when it ends, so a failed request count showed no JMeter output. Snapshot each pod's logs and the namespace's events while the test runs, and print them when the count is wrong. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On kind v0.11.1 the JMeter pods' Java 11 can't read the cgroup v2 layout of current GitHub runners and logs a NullPointerException while log4j registers its JMX beans. The JMeter master's launcher treats any ERROR line as a failure, so it stopped the run after about 10 seconds and the request count came up short. Newer kind gives each pod its own cgroup namespace. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On current GitHub runners, the default JMeter image's Java 11 can't read the cgroup v2 layout: log4j logs a NullPointerException as an ERROR while it registers its JMX beans. The master's launcher stops the test on any ERROR line, so the run ended after about 10 seconds and the integration test counted too few requests. LOG4J_DISABLE_JMX skips that registration, which Kangal doesn't use. The kind upgrade didn't change that error, so kind is back to v0.11.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
etiennechabert
marked this pull request as ready for review
November 12, 2026 16:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Testcheck has failed on every pull request since 28 January at the JMeter request count inci/integration-tests.sh("sent 16 requests, but 60 requests were expected"), which blocks unrelated PRs such as #409.Cause: on current GitHub runners, the default JMeter image's Java 11 (
openjdk:11-jre-slim) throws aNullPointerExceptioninCgroupV2Subsystem.getInstancewhen log4j registers its JMX beans. log4j logs it asmain ERROR Could not reconfigure JMX. The error is harmless (the workers hit it too and keep running), but the master'slauncher.shstops the test on any line containingERROR. The job fails, the JMeter backend reports the failed job asfinished, and the Go test deletes the load test about 10 seconds into its 30-second run.Fix:
pkg/backends/jmeter/resources.go: setLOG4J_DISABLE_JMX=trueon the JMeter master. log4j 2.17.2 (shipped with JMeter 5.5) maps it tolog4j2.disable.jmxand then skips the platform MBean server entirely. Kangal doesn't use log4j's JMX beans, and the variable doesn't overrideJVM_ARGSfrom a custom image.ci/integration-tests.sh: keep each JMeter pod's logs and the namespace's events while the test runs, and print them when the request count is wrong. The test deletes its namespace when it ends, so this output was previously lost.Upgrading kind (v0.11.1 to v0.27.0) was tried and didn't change the Java error, so CI stays on v0.11.1.
TestandLintpass on this branch.🤖 Generated with Claude Code