Skip to content

Add a Couple New Posts - #75

Open
hisaac wants to merge 2 commits into
mainfrom
hisaac/new-posts
Open

Add a Couple New Posts#75
hisaac wants to merge 2 commits into
mainfrom
hisaac/new-posts

Conversation

@hisaac

@hisaac hisaac commented May 22, 2025

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings May 22, 2025 12:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces two new blog posts aimed at sharing insights into mobile CI practices and the challenges of building Catalyst apps on CI.

  • Adds a blog post on “Tips & Tricks for Mobile CI” with detailed guidance and code examples.
  • Adds a blog post on “Difficulties of Building Catalyst Apps on CI” discussing challenges and possible solutions in CI environments.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/content/blog/2025/Tips & Tricks for Mobile CI.md Introduces a new post with tips on mobile CI, including command runner usage and a shell script for notarizing binaries.
src/content/blog/2025/Difficulties of Building Catalyst Apps on CI.md Adds a new post discussing the unique challenges of building and testing Catalyst apps in CI pipelines.
Comments suppressed due to low confidence (1)

src/content/blog/2025/Tips & Tricks for Mobile CI.md:187

  • The '-p | --profileName' case mistakenly assigns its argument to 'productName' instead of 'profileName'. Update the assignment to correctly set 'profileName'.
-p | --profileName )    shift productName="$1"

zip -r "product/${productName}.zip" "product/$productName"

# upload to notary
xcrun notarytool submit "product/${productName}.zip" -p "$keychainProfileName"

Copilot AI May 22, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submission command uses 'keychainProfileName', which appears inconsistent with the expected 'profileName'. Consider renaming it for consistency and to avoid potential errors.

Suggested change
xcrun notarytool submit "product/${productName}.zip" -p "$keychainProfileName"
xcrun notarytool submit "product/${productName}.zip" -p "$profileName"

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll update this locally.

@netlify

netlify Bot commented May 22, 2025

Copy link
Copy Markdown

Deploy Preview for hisaac-net ready!

Name Link
🔨 Latest commit 5d9b047
🔍 Latest deploy log https://app.netlify.com/projects/hisaac-net/deploys/692dcf5c5a1cfe0008eccbdc
😎 Deploy Preview https://deploy-preview-75--hisaac-net.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants