Skip to content

fix: remove scroll position workaround for fixed Claude Code issue #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hlibkoval merged 1 commit into from
Jan 29, 2026
Merged

fix: remove scroll position workaround for fixed Claude Code issue #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 0 additions & 47 deletions src/view/scroll-position-manager.ts
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions src/view/terminal-view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { FitAddon } from "@xterm/addon-fit";
import { getThemeColors } from "../theme/xterm-theme";
import { injectXtermCSS } from "../theme/xterm-css";
import { TerminalProcess, connectTerminalToProcess, ClaudeCommandOptions } from "../terminal/terminal-process";
import { ScrollPositionManager } from "./scroll-position-manager";
import type VaultCodePlugin from "../main";

export const VIEW_TYPE = "vault-terminal";
Expand All @@ -19,7 +18,6 @@ export class TerminalView extends ItemView {
private escapeScope: Scope | null = null;
private fitTimeout: ReturnType<typeof setTimeout> | null = null;
private plugin: VaultCodePlugin;
private scrollManager = new ScrollPositionManager();

constructor(leaf: WorkspaceLeaf, plugin: VaultCodePlugin) {
super(leaf);
Expand Down Expand Up @@ -140,9 +138,6 @@ export class TerminalView extends ItemView {

// Watch for Obsidian layout changes (sidebar resize, etc.)
this.registerEvent(this.app.workspace.on("layout-change", () => this.debouncedFit()));

// Mitigate Ink TUI scroll-to-top bug (Claude Code issue #826)
this.scrollManager.attach(this.term);
}

private updateTheme(): void {
Expand Down Expand Up @@ -250,8 +245,6 @@ export class TerminalView extends ItemView {
this.fitTimeout = null;
}

this.scrollManager.dispose();

if (this.escapeScope) {
this.app.keymap.popScope(this.escapeScope);
this.escapeScope = null;
Expand Down
210 changes: 0 additions & 210 deletions tests/view/scroll-position-manager.test.ts
View file
Open in desktop

This file was deleted.