Repository navigation
fix(plot): honour the three-state block contract - #2
Closed
huxiaoyi-ovo wants to merge 5 commits into
Closed
huxiaoyi-ovo wants to merge 5 commits into
huxiaoyi-ovo wants to merge 5 commits into
Conversation
Align plot() and highlight_path() with the RVC block contract without changing explicit True/False handling. Co-Authored-By: ChatGPT (OpenAI GPT-6) <noreply@openai.com>
Co-Authored-By: ChatGPT (OpenAI GPT-6) <noreply@openai.com>
Co-Authored-By: ChatGPT (OpenAI GPT-6) <noreply@openai.com>
Co-Authored-By: ChatGPT (OpenAI GPT-6) <noreply@openai.com>
Owner
Author
|
Fork-only validation complete: all required CI checks passed. The same head commit has been submitted upstream as petercorke#84. Closing this staging draft PR to keep the fork tidy; the upstream PR and source branch remain unchanged. |
Co-Authored-By: ChatGPT (OpenAI GPT-6) <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-only validation for pgraph-python #79; not intended to be merged into the fork.
Change
Graph.plot()andGraph.highlight_path()now default toblock=None, leaving figure display to the environment. ExplicitFalseandTrueretain their existing show semantics.docs/llms_intro.md.plt.show, explicitblock=False/True, and same-axes highlighting.Verification
mainat74402d5.block=Falseor callplt.show()after drawing all overlays.Upstream submission
Issue petercorke#79 has been claimed by huxiaoyi-ovo. No duplicate upstream PR found. Ready to submit upstream via GitHub website, because the integration lacks cross-repository PR creation permissions (GitHub API 403).
AI assistance: ChatGPT (OpenAI GPT-6) helped review, implement and test this change.