[codex] Lower grouped integer widening to unpack - #1250
Merged
Zhendong404 merged 3 commits intoAug 18, 2026
Conversation
Zhendong404
force-pushed
the
codex/vmi-integer-unpack
branch
from
August 17, 2026 08:14
7cf571d to
67930a9
Compare
Zhendong404
marked this pull request as ready for review
August 18, 2026 02:31
Zhendong404
force-pushed
the
codex/vmi-integer-unpack
branch
from
August 18, 2026 02:56
67930a9 to
a913cf4
Compare
Zhendong404
force-pushed
the
codex/vmi-integer-unpack
branch
from
August 18, 2026 03:20
a913cf4 to
c1f1d2f
Compare
mouliangyu
requested changes
Aug 18, 2026
mouliangyu
left a comment
Collaborator
There was a problem hiding this comment.
P1: test/lit/vmi_new/vmi_to_vpto_group_slot_integer_unpack.pto:69-70 的 CHECK 仍匹配 !pto.vreg<256xi8>/!pto.vreg<128xi16>,但测试输入已改为 signed 类型,实际输出是 !pto.vreg<256xsi8> -> !pto.vreg<128xsi16>。因此 build-and-test 仍失败(1808 个测试中 1 个失败)。请将这些 CHECK 更新为 si8/si16 后重新运行 lit。
Zhendong404
force-pushed
the
codex/vmi-integer-unpack
branch
from
August 18, 2026 07:30
6d2058d to
50b39eb
Compare
mouliangyu
approved these changes
Aug 18, 2026
mouliangyu
left a comment
Collaborator
There was a problem hiding this comment.
已确认上次提出的 signed integer FileCheck 问题修复:检查现已使用 si8/si16,与实际 vsunpack 输出一致。重新检视完整变更集后未发现新的阻塞问题。当前 vpto-sim-validation 失败发生在 git ls-remote 拉取 LLVM 时(Failure when receiving data from the peer),属于基础设施网络错误,建议重跑该 job;build-and-test 仍在运行。
A3 板测失败
失败用例
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vsunpack/vzunpack.Validation
cmake --build build -j8 --target pto-test-optDraft note: TileLang codegen probing is being validated separately; the current generated PTODSL still shows a direct BF16-to-F32
vmi.vcvtin the end-to-end per-token case.