Skip to content

Bundle external schemas referenced relative to an embedded schema's $id - #148

Open
trackoor wants to merge 1 commit into
hyperjump-io:mainfrom
trackoor:fix-bundle-nested-id-refs
Open

trackoor wants to merge 1 commit into
hyperjump-io:mainfrom
trackoor:fix-bundle-nested-id-refs

Conversation

@trackoor

Copy link
Copy Markdown

Fixes #144.

doBundling skipped any reference that pointed at an embedded schema, so external $refs inside that embedded schema (resolved against its own $id) were never collected. Now it still walks into the embedded schema, without embedding it again.

Added a bundle test case for it. It fails without the change and passes with it. The 9 multipleOf very small number failures in the full suite also happen on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bundle() does not embed schemas referenced relative to a nested $id

1 participant