Repository navigation
Conversation
v1 defines hostname without IDNA rules (RFC 1123), allowing '--' in the 3rd and 4th positions (e.g. 'ab--cd.example'). Point v1 to the RFC 1123 hostname handler instead of the IDNA handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #150
Summary
In JSON Schema v1,
format: "hostname"is defined without the IDNA A-label clause (unlike draft-07 through draft-2020-12). Hostnames containing--in positions 3 and 4 (such as"ab--cd.example") are valid RFC 1123 hostnames.This updates
lib/keywords/format.jsto map"hostname"to the RFC 1123 handler (https://json-schema.org/format/draft-04/hostname), resolving the test suite failure inv1/json-schema-test-suite.spec.ts.Verification
npm testpasses completely (15,265 tests across all 29 test files)npm run lintpassesnpm run check-typespasses