Repository navigation
Keep the root $ref when bundling a draft-04/06/07 schema - #154
Open
drishtyraghav0001 wants to merge 1 commit into
Open
drishtyraghav0001 wants to merge 1 commit into
drishtyraghav0001 wants to merge 1 commit into
Conversation
bundle() followed a legacy root $ref before serializing, so the entry schema was replaced by the target document. Keep the $ref and embed the referenced document, and still discover embedded $ids that sit next to that $ref so the bundle validates on its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #145.
bundle()was following a legacy root$refbefore serializing, so a draft-04/06/07 schema whose root is a$refcame back as the target document. It now keeps the entry schema and embeds the referenced document, the same way 2019-09 and 2020-12 already did.The bundle also needs the embedded
$ids indefinitionsto be discovered even though they sit next to that root$ref, otherwise registering the bundle can't resolve the reference on its own.Added tests for it. They fail without the change and pass with it.
npm test, lint, and type-check all pass (15284 tests).