Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
sakithb
reviewed
Oct 26, 2026
Collaborator
There was a problem hiding this comment.
Why is this file added in here?
Member
Author
There was a problem hiding this comment.
My bad, I bumped design to 2.2.1 locally, which removed HeaderLanguageToggle from /marketing, so I copied it to make the build pass. It's unrelated to this PR, so I've reverted the frontend changes.
supun-io
requested changes
Oct 27, 2026
| $sendUpdates = new UpdateSendDto(); | ||
| $sendUpdates->unsubscribeAt = $this->now(); | ||
| $this->sendService->updateSend($send, $sendUpdates); | ||
| } |
Member
There was a problem hiding this comment.
I think this should handle the reverse as well.
If the user resubscribes again, and it we marked this user as unsubscribed earlier, we have to revert that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #474