Refactor the activity log: two views, a scope-preview popup, one shared state machine - #39
Open
iTerminate wants to merge 5 commits into
Open
Refactor the activity log: two views, a scope-preview popup, one shared state machine#39iTerminate wants to merge 5 commits into
iTerminate wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LogbookController(src/hatty/controllers/logbook.py), unifying the previously-duplicated scope/paging/fetch/subscription state machine shared byHACLI's docked activity log panel andGraphPreviewScreen's.LogOptionList) with an inline untruncated detail region, instead of just widening the passive ticker.v's blind scope cycle withLogScopePopup: a preview-then-commit popup listing every scope option with live entity/device names and cap notices.LogEntryPopup— its only job (showing one entry's untruncated text) is now covered by the maximized panel's detail region.Closes #38.
Test plan
pytestsuite green (1275 passed; one pre-existing, unrelated timing flake intest_media_player_control.pyconfirmed on isolated re-run)uv run ruff check .cleanuv run pyrightclean